Skip to content

Commit 2adf3ea

Browse files
committed
code review
1 parent d22170d commit 2adf3ea

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

airbyte_cdk/sources/declarative/declarative_component_schema.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3325,7 +3325,7 @@ definitions:
33253325
- ["code", "type"]
33263326
PropertiesFromEndpoint:
33273327
title: Properties from Endpoint
3328-
description: Defines the behavior for fetching the list of properties from an API that will be loaded into the requests to extract records.
3328+
description: Defines the behavior for fetching the list of properties from an API that will be loaded into the requests to extract records. Note that stream_slices can't be interpolated from this retriever.
33293329
type: object
33303330
required:
33313331
- type

airbyte_cdk/sources/declarative/requesters/query_properties/properties_from_endpoint.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ def get_properties_from_endpoint(self) -> List[str]:
3535
self._cached_properties = list(
3636
map(
3737
self._get_property, # type: ignore # SimpleRetriever and AsyncRetriever only returns Record. Should we change the return type of Retriever.read_records?
38-
self.retriever.read_records(
39-
records_schema={}, stream_slice=StreamSlice(partition={}, cursor_slice={})
40-
),
38+
self.retriever.read_records(records_schema={}, stream_slice=None),
4139
)
4240
)
4341
return self._cached_properties

0 commit comments

Comments
 (0)