Skip to content

Commit 300f9e6

Browse files
committed
Consolidate new examples into existing test functions
1 parent 88da3b7 commit 300f9e6

File tree

2 files changed

+6
-30
lines changed

2 files changed

+6
-30
lines changed

tests/sqlparser_common.rs

Lines changed: 5 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -16535,10 +16535,8 @@ fn parse_create_procedure_with_parameter_modes() {
1653516535
}
1653616536
_ => unreachable!(),
1653716537
}
16538-
}
1653916538

16540-
#[test]
16541-
fn create_procedure_with_parameter_default_value() {
16539+
// parameters with default values
1654216540
let sql = r#"CREATE PROCEDURE test_proc (IN a INTEGER = 1, OUT b TEXT = '2', INOUT c TIMESTAMP = NULL, d BOOL = 0) AS BEGIN SELECT 1; END"#;
1654316541
match verified_stmt(sql) {
1654416542
Statement::CreateProcedure {
@@ -16549,51 +16547,31 @@ fn create_procedure_with_parameter_default_value() {
1654916547
} => {
1655016548
assert_eq!(or_alter, false);
1655116549
assert_eq!(name.to_string(), "test_proc");
16552-
let fake_span = Span {
16553-
start: Location { line: 0, column: 0 },
16554-
end: Location { line: 0, column: 0 },
16555-
};
1655616550
assert_eq!(
1655716551
params,
1655816552
Some(vec![
1655916553
ProcedureParam {
16560-
name: Ident {
16561-
value: "a".into(),
16562-
quote_style: None,
16563-
span: fake_span,
16564-
},
16554+
name: Ident::new("a"),
1656516555
data_type: DataType::Integer(None),
1656616556
mode: Some(ArgMode::In),
1656716557
default: Some(Expr::Value((number("1")).with_empty_span())),
1656816558
},
1656916559
ProcedureParam {
16570-
name: Ident {
16571-
value: "b".into(),
16572-
quote_style: None,
16573-
span: fake_span,
16574-
},
16560+
name: Ident::new("b"),
1657516561
data_type: DataType::Text,
1657616562
mode: Some(ArgMode::Out),
1657716563
default: Some(Expr::Value(
1657816564
Value::SingleQuotedString("2".into()).with_empty_span()
1657916565
)),
1658016566
},
1658116567
ProcedureParam {
16582-
name: Ident {
16583-
value: "c".into(),
16584-
quote_style: None,
16585-
span: fake_span,
16586-
},
16568+
name: Ident::new("c"),
1658716569
data_type: DataType::Timestamp(None, TimezoneInfo::None),
1658816570
mode: Some(ArgMode::InOut),
1658916571
default: Some(Expr::Value(Value::Null.with_empty_span())),
1659016572
},
1659116573
ProcedureParam {
16592-
name: Ident {
16593-
value: "d".into(),
16594-
quote_style: None,
16595-
span: fake_span,
16596-
},
16574+
name: Ident::new("d"),
1659716575
data_type: DataType::Bool,
1659816576
mode: None,
1659916577
default: Some(Expr::Value((number("0")).with_empty_span())),

tests/sqlparser_mssql.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -198,10 +198,8 @@ fn parse_mssql_create_procedure() {
198198
let _ = ms().verified_stmt("CREATE PROCEDURE [foo] AS BEGIN SELECT [foo], CASE WHEN [foo] IS NULL THEN 'empty' ELSE 'notempty' END AS [foo]; END");
199199
// Multiple statements
200200
let _ = ms().verified_stmt("CREATE PROCEDURE [foo] AS BEGIN UPDATE bar SET col = 'test'; SELECT [foo] FROM BAR WHERE [FOO] > 10; END");
201-
}
202201

203-
#[test]
204-
fn parse_mssql_create_procedure_with_parameter_default_value() {
202+
// parameters with default values
205203
let sql = r#"CREATE PROCEDURE foo (IN @a INTEGER = 1, OUT @b TEXT = '2', INOUT @c DATETIME = NULL, @d BOOL = 0) AS BEGIN SELECT 1; END"#;
206204
let _ = ms().verified_stmt(sql);
207205
}

0 commit comments

Comments
 (0)