V2 refactor #22
Merged
V2 refactor #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 5, 2025 20:19
…concise record_failure(message: str, event_data: obj = {}) signature. This means:
All record_failure calls now use a message as the first argument, and any additional error data as the second argument (if needed).
Manual assignments to event.data or event.event_data before/after failure have been removed.
All exception handling in the clean routes and service save/delete/lock methods is now consistent and clear.
added 28 commits
July 10, 2025 19:22
- Uncommented Cleanup (Delete Test Dictionary) step - All 7 steps now passing: Create, Get, Update, Lock, Delete locked, Unlock, Cleanup - Complete dictionary workflow tested and working correctly
…ports modern schema. Update tests to match. No backward compatibility or legacy code remains.
…rsion field, no properties for void type)
…ration tests for required property behavior, all tests passing
…e type is unlocked before deletion
… to ensure configuration is unlocked before deletion
…nlock steps before deletion for types and configurations endpoints
…ion objects for consistency with other routes
…orException and Exception patterns
…pCI tests - Fixed lock_all methods in dictionary, configuration, and type services to call record_success() at the end - Updated stepCI tests to match actual API response format (removed data.total_files and data.operation expectations) - All unit tests and stepCI tests now pass for lock_all endpoints
- Replace placeholder migrations test with full CRUD operations - Test GET, PUT, DELETE endpoints for migration files - Verify JSON pipeline content and file metadata - All 6 test steps pass successfully
…write and verify enumerators)
… implementation
- Enumerators: GET returns { enumerators: [...] }, PUT request is array, response is file metadata
- Migrations: GET/PUT are array (aggregation pipeline), DELETE returns ConfiguratorEvent
- Ensures docs reflect actual API behavior for CI and client use
…correct API format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a complete reflector. Version one code relied very heavily on cursor for both design and architecture as well as cogeneration. As a result of this the code was very task oriented and difficult to follow. It did however excite my imagination about what would be possible if I shifted to a more service model driven architecture, and properly implemented exception handling. Version two leveraged much more tab to complete assistance from cursor than it did chat and build. Once the code was at a sufficient point where we could do unit testing I did shift more to relying on cursor to write code, they are really good at writing tests. Once the unit testing and integration testing was complete cursor proved to be exceptionally talented at building effective step CI blackbox testing.