sbe-tool nuget package is DOA

[damageboy]

When using the sbe-tool from the latest sbe-tool nuget package: 0.1.12-1-beta-1, code generation immediately fails

Exception in thread "main" java.lang.NoClassDefFoundError: org/agrona/MutableDirectBuffer
        at uk.co.real_logic.sbe.SbeTool.<clinit>(SbeTool.java:82)
Caused by: java.lang.ClassNotFoundException: org.agrona.MutableDirectBuffer
        at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:583)
        at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
        ... 1 more

It seems that the nuget package contains the WRONG jar, it should have contained the jar from the: sbe-all/build/libs/ folder which contains all the required java deps, but instead it uses the jar from the sbe-tool/build/libs/ folder which is partial as far as running the complete sbe-tool is...

Would it be OK for me submit a PR that fixes this and for someone who has access to the nuget account (I presume @billsegall) to publish an updated nuget package?

As far as I can tell, this thing is dead out of water from nuget....

[mjpt777]

It looks like their are a number of issues worth addressing with the C# implementation. It would be good for those interested to jointly agree on how best to improve it and I'll happily support that.

[damageboy]

I wouldn't mind taking a few concentrated days to try and bring it more up to speed..., looks to me like we need:

• CI support for the C# parts
• Automatic packaging / myget feed per build
• Running unit tests on the build server (e.g. building + running everything on Linux as part of the current travis build)

Would you like me to first try and get the C# parts of the project into a working state?

[mjpt777]

That would be great. Then maybe @billsegall, @JPWatson, @ZachBray and whoever else is interested can feedback and agree changes.

[damageboy]

OK, the only annoyance is that I've already done some build related touch-ups as part of #695

It would be easier to me if someone could review that and merge that so I could branch off of that to start the CI related stuff, but if that's not possible in the short-term, let me know and I'll redo that work in a new branch dedicated to the CI status

[billsegall]

It would seem I broke this with 8b9bda8

Can anyone provide context on why the '-all' jar stopped building. I had wrongly assumed it had just changed name.

I'm on the road holidaying with limited internet/facilities for the next three weeks but will try to chime in when I can.

[damageboy]

@billsegall I think I have something working in #699

There's a ton of small fixes there, and once travis does its thing, I think you can push a new nuget from there...

[damageboy]

travis now seems to build this properly... (#699)

Once merged I think we can release a new nuget package after someone can test it except for me :)

[mjpt777]

What is the status of the nuget package? If we do a new release in a few days what is required?

[billsegall]

I'll be back at my desk on Monday and will publish a new version. Long term we need to make this possible at a project level. Bill

…

On Thu., 1 Aug. 2019, 7:36 pm Martin Thompson, ***@***.***> wrote: What is the status of the nuget package? If we do a new release in a few days what is required? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#698>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABJDLJGIC5QDVQRR3725LJTQCMNJJANCNFSM4IEPZA6A> .

[mjpt777]

Thanks @billsegall. Should we hold off on a release until after Monday?

[billsegall]

Go for it now. If there is a problem we can fix it after and it's nice to be close to an official release. Bill.

…

On Fri., 2 Aug. 2019, 9:33 am Martin Thompson, ***@***.***> wrote: Thanks @billsegall <https://github.com/billsegall>. Should we hold off on a release until after Monday? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#698>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABJDLJC2BXNKZSUL5XEY42LQCPPMRANCNFSM4IEPZA6A> .

[damageboy]

Great!
All I can say is that I've been using it from an internal feed, and as far as I can tell it's working well (codegen + generated code).

[billsegall]

Heh. Won't be Monday, I'm having one of those air travel nightmares on a super long haul flight. Bill

…

On Fri., 2 Aug. 2019, 9:39 am Bill Segall, ***@***.***> wrote: Go for it now. If there is a problem we can fix it after and it's nice to be close to an official release. Bill. On Fri., 2 Aug. 2019, 9:33 am Martin Thompson, ***@***.***> wrote: > Thanks @billsegall <https://github.com/billsegall>. Should we hold off > on a release until after Monday? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#698>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABJDLJC2BXNKZSUL5XEY42LQCPPMRANCNFSM4IEPZA6A> > . >

[mjpt777]

Sorry to hear that. Travel can be a pain at times. Hopefully gets better.

[damageboy]

Other than the official package at nuget.org, I can also setup some sort of a ci nuget feed on myget or something of that source, if that is of any interest...

I would make consuming ci packages a real possibility, although that might be over the top.