Skip to content

[C#] Overhal unit testing state #592

Open
@damageboy

Description

@damageboy

As mentioned in the discussion for another PR there are some issues with the current state of sbe-dll unit tests, to summerise what I'm seeing and what @ZachBray mentioned:

  • I can't get tests to run on Linux (possible because of MS test frameowrk? not sure why)
  • Tests aren't targeting netcoreapp2.1/2.0 at all, so not .NET Core testing isn't happening
  • Tests are targeting net45 as of now, which doesn't officially support the .NET framework that is the minimal requirement for sbe-dll.dll which is targeting netstandard2.0.
  • tests are not run as part of the gradle build at all, AFAICT gradle only generates the csharp source code from sbe schema with no dotnet build being invoked at all, so I think, we probably want separate
    I think we would/should want tests to be able to run on an OS (Linux+Windows), using the standard toolset (e.g. dotnet test) from the travis build script

If that requires porting tests to NUnit/XUnit, let's make that call (though I admit I can't find anywhere saying MSTest won't work on Linux, I just can't get it to run right now).

Any thoughts about this?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions