Skip to content

Commit 4c076e3

Browse files
fix(menuitem): add aria-current logic
- for role="menuitem", set aria-current="true" if selected, but do not add aria-current="false" if not selected as it's unnecessary
1 parent 032ac2d commit 4c076e3

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

1st-gen/packages/menu/src/MenuItem.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -719,6 +719,13 @@ export class MenuItem extends LikeAnchor(
719719

720720
updateAriaSelected(): void {
721721
const role = this.getAttribute('role');
722+
if (role === 'menuitem') {
723+
if (this.selected) {
724+
this.setAttribute('aria-current', 'true');
725+
} else {
726+
this.removeAttribute('aria-current');
727+
}
728+
}
722729
if (role === 'option') {
723730
this.setAttribute(
724731
'aria-selected',

0 commit comments

Comments
 (0)