Skip to content

Minimal changes upgrade intl messages #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2021
Merged

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented May 5, 2021

Closes #1849

One note/question does upgrading this dep by a major version count as a breaking change for users of our library? I don't think so as they can have their own copy of intl

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger snowystinger added the small review Easy to review PR label May 12, 2021
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested a couple of locales with a couple of components, things like aria-labels and stuff seem to be getting localized properly still.

@adobe-bot
Copy link

Build successful! 🎉

@snowystinger snowystinger merged commit a60427f into main May 18, 2021
@snowystinger snowystinger deleted the upgrade-intl-messages-minimal branch May 18, 2021 19:00
majornista pushed a commit to majornista/react-spectrum-v3 that referenced this pull request May 19, 2021
Upgrade intl messages from 2.* to 9.*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small review Easy to review PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken on snowpack, bump intl-messageformat
4 participants