Skip to content

Use StrictMode in integration tests #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2019
Merged

Use StrictMode in integration tests #1664

merged 2 commits into from
May 21, 2019

Conversation

nstepien
Copy link
Contributor

 PASS  tests/ReactDataGrid.test.ts
  √ rendering <ReactDataGrid /> should work (61ms)

  console.error node_modules/react-dom/cjs/react-dom.development.js:506
    Warning: Unsafe lifecycle methods were found within a strict-mode tree:
        in StrictMode
    
    componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: Header, ReactDataGrid, Viewport
    
    Learn more about this warning here:
    https://fb.me/react-strict-mode-warnings

  console.error node_modules/react-dom/cjs/react-dom.development.js:506
    Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of HeaderRow which is inside StrictMode. Instead, add a ref directly to the element you want to reference.
    
        in div (created by HeaderRow)
        in HeaderRow (created by Header)
        in div (created by Header)
        in Header (created by Grid)
        in div (created by Grid)
        in Grid (created by ReactDataGrid)
        in div (created by ReactDataGrid)
        in ReactDataGrid
        in StrictMode
    
    Learn more about using refs safely here:
    https://fb.me/react-strict-mode-find-node

@nstepien nstepien requested a review from amanmahajan7 May 20, 2019 11:52
@nstepien nstepien self-assigned this May 20, 2019
@amanmahajan7 amanmahajan7 merged commit 8687b2b into next May 21, 2019
@amanmahajan7 amanmahajan7 deleted the strictmode branch May 21, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants