Skip to content

[Snyk] Security upgrade electron-rebuild from 1.11.0 to 3.2.4 #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: CircleCI-v2
Choose a base branch
from

Conversation

adamlaska
Copy link
Owner

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • examples/run-in-electron/package.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
medium severity 658/1000
Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS)
SNYK-JS-SEMVER-3247795
Yes Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: electron-rebuild The new version differs by 250 commits.
  • 801f3e0 chore(deps-dev): bump @ types/node from 16.11.1 to 16.11.7
  • c8e1211 chore(deps-dev): bump @ typescript-eslint/parser from 4.32.0 to 4.33.0
  • 3213261 chore(deps): bump node-abi from 3.2.0 to 3.3.0
  • 2fb3172 chore(deps-dev): bump @ types/tar from 4.0.5 to 6.1.0
  • c17ee57 Merge pull request #883 from electron/dependabot/npm_and_yarn/typescript-eslint/eslint-plugin-4.33.0
  • cd088fb chore(deps-dev): bump @ types/yargs from 17.0.3 to 17.0.4
  • ce03ed8 chore(deps-dev): bump mocha from 9.1.2 to 9.1.3
  • 39a98cd chore(deps-dev): bump @ types/node from 16.10.3 to 16.11.1
  • 23bbcdb chore(deps-dev): bump typescript from 4.4.3 to 4.4.4
  • 12ed1c9 chore(deps-dev): bump ts-node from 10.2.1 to 10.3.0
  • f32f0b3 Merge pull request #887 from electron/dependabot/npm_and_yarn/types/node-16.10.3
  • 97b2f27 chore(deps-dev): bump @ types/node from 16.10.2 to 16.10.3
  • 0d36824 fix: force release
  • 73b7bc2 chore(deps-dev): bump @ typescript-eslint/eslint-plugin
  • f6ca720 chore(deps-dev): bump @ types/node from 16.10.1 to 16.10.2
  • e0ca555 chore(deps): bump yargs from 17.1.1 to 17.2.1
  • 44fd667 chore(deps-dev): bump mocha from 9.1.1 to 9.1.2
  • 39986a4 chore(deps-dev): bump @ types/node from 16.9.4 to 16.10.1
  • 4b14999 chore(deps-dev): bump @ typescript-eslint/eslint-plugin
  • b821529 chore(deps-dev): bump @ typescript-eslint/parser from 4.31.2 to 4.32.0
  • 1e85769 chore(deps): bump node-abi from 3.0.0 to 3.2.0
  • 496455d chore(deps-dev): bump @ types/fs-extra from 9.0.12 to 9.0.13
  • 0eba957 chore(deps-dev): bump @ types/chai from 4.2.21 to 4.2.22
  • cf13512 chore(deps-dev): bump @ types/yargs from 17.0.2 to 17.0.3

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

@google-cla
Copy link

google-cla bot commented Jun 21, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Native code lzma-native 8.0.6 examples/run-in-electron/package.json via [email protected]
Network access http2-wrapper 1.0.3 examples/run-in-electron/package.json via [email protected]
Network access resolve-alpn 1.2.1 examples/run-in-electron/package.json via [email protected]
Network access electron-rebuild 3.2.9 examples/run-in-electron/package.json
Network access got 11.8.6 examples/run-in-electron/package.json via [email protected]
Network access cacheable-lookup 5.0.4 examples/run-in-electron/package.json via [email protected]

Next steps

What's wrong with native code?

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
electron-rebuild ⬆️ 1.11.0...3.2.9 network, shell, environment +49/-15 10.4 MB electron-cfa

Footnotes

  1. https://docs.socket.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants