Skip to content

[Snyk] Security upgrade ipfs from 0.30.0 to 0.64.0 #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: CircleCI-v2
Choose a base branch
from

Conversation

adamlaska
Copy link
Owner

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • examples/exchange-files-in-browser/package.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
medium severity 658/1000
Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS)
SNYK-JS-SEMVER-3247795
No Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: ipfs The new version differs by 250 commits.
  • 89aeaf8 chore: release master (#4189)
  • 051da16 deps: update libp2p to 0.39.0 (#4203)
  • bb78ebf deps: upgrade @ multiformats/multiaddr to 10.4.0 (#4178)
  • 83f9882 fix: query input types (#4201)
  • c6d03ec docs: clarify state of DHT in js-ipfs (#4181)
  • cb3533a docs: Update README.md (#4192)
  • 8f351a8 chore: linting
  • 39dbf70 deps!: update to [email protected] (#4151)
  • 7a7e091 chore: update docs/core-api/README (#4159)
  • 3b25957 chore: houseclean README (#4157)
  • e14dab8 chore: Update .github/workflows/stale.yml [skip ci]
  • 3e7353f chore: houseclean ipfs/README (#4156)
  • 89db371 chore: houseclean interface-ipfs-core/README (#4158)
  • a05695f chore: houseclean ipfs-core/README (#4160)
  • d5c1a54 Update .github/workflows/stale.yml
  • 965f5a4 chore: release master (#4146)
  • 00bd3dd fix: make pubsub message types consistent (#4145)
  • c1cbc81 chore: update changelogs (#4144)
  • 5a9039a chore: release master (#4143)
  • 7be50bd fix: use default ws filters instead of connecting to everything (#4142)
  • 0078aad chore: release master (#4132)
  • 70e142a chore: cleanup changelog (#4129)
  • 129ac77 fix: onMessage assignment should be undefined not null (#4131)
  • 92155bc Add .github/workflows/stale.yml

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

@google-cla
Copy link

google-cla bot commented Jun 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Native code classic-level 1.3.0 examples/exchange-files-in-browser/package.json via [email protected]
HTTP dependency electron-eval 0.9.10 examples/exchange-files-in-browser/package.json via [email protected]
Install scripts wrtc 0.4.7
  • Install script: install
  • Source: node scripts/download-prebuilt.js
examples/exchange-files-in-browser/package.json via [email protected]
Install scripts protobufjs 6.11.3
  • Install script: postinstall
  • Source: node scripts/postinstall
examples/exchange-files-in-browser/package.json via [email protected]
Network access protobufjs 6.11.3 examples/exchange-files-in-browser/package.json via [email protected]
Install scripts protobufjs 7.2.3
  • Install script: postinstall
  • Source: node scripts/postinstall
examples/exchange-files-in-browser/package.json via [email protected]
Network access protobufjs 7.2.3 examples/exchange-files-in-browser/package.json via [email protected]
Install scripts iso-constants 0.1.2
  • Install script: install
  • Source: node build.js > index.browser.js
examples/exchange-files-in-browser/package.json via [email protected]
Network access @grpc/grpc-js 1.8.15 examples/exchange-files-in-browser/package.json via [email protected]
Network access http2-wrapper 2.2.0 examples/exchange-files-in-browser/package.json via [email protected]
Network access resolve-alpn 1.2.1 examples/exchange-files-in-browser/package.json via [email protected]
Network access undici 5.22.1 examples/exchange-files-in-browser/package.json via [email protected]
Network access @protobufjs/fetch 1.1.0
  • Module: globalThis["fetch"]
  • Location: index.js
examples/exchange-files-in-browser/package.json via [email protected]
Network access electron-fetch 1.9.1 examples/exchange-files-in-browser/package.json via [email protected]
Network access ipfs-utils 9.0.14 examples/exchange-files-in-browser/package.json via [email protected]
Network access it-multipart 2.0.2
  • Module: globalThis["fetch"]
  • Location: test.js
examples/exchange-files-in-browser/package.json via [email protected]
Network access @hapi/hapi 20.3.0 examples/exchange-files-in-browser/package.json via [email protected]
Network access @hapi/wreck 17.2.0 examples/exchange-files-in-browser/package.json via [email protected]
Network access needle 2.9.1 examples/exchange-files-in-browser/package.json via [email protected]
Network access @libp2p/tcp 3.1.2 examples/exchange-files-in-browser/package.json via [email protected]
Network access default-gateway 6.0.3 examples/exchange-files-in-browser/package.json via [email protected]
Network access private-ip 2.3.4 examples/exchange-files-in-browser/package.json via [email protected]
Network access private-ip 3.0.0 examples/exchange-files-in-browser/package.json via [email protected]
Network access @achingbrain/ssdp 4.0.4 examples/exchange-files-in-browser/package.json via [email protected]
Network access @hapi/shot 5.0.5 examples/exchange-files-in-browser/package.json via [email protected]
Network access config-chain 1.1.13 examples/exchange-files-in-browser/package.json via [email protected]
Network access pino-std-serializers 3.2.0 examples/exchange-files-in-browser/package.json via [email protected]

Next steps

What's wrong with native code?

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.

What are http dependencies?

Contains a dependency which resolves to a remote HTTP URL which could be used to inject untrusted code and reduce overall package reliability.

Publish the HTTP URL dependency to npm or a private package repository and consume it from there.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

What is network access?

This module accesses the network.

Packages should remove all network access that isn't functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
ipfs ⬆️ 0.30.0...0.64.0 None +507/-9 68.2 MB npm-service-account-ipfs

Footnotes

  1. https://docs.socket.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants