Skip to content

Feature: default UART (serial) #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 17, 2018
Merged

Feature: default UART (serial) #845

merged 7 commits into from
May 17, 2018

Conversation

matt-land
Copy link

This implements default UART in atmel-samd boards, similar to how I2C and SPI work.

>>> import board
>>> board.UART()
<UART>

Boards were chosen for support for having all of the following defined in pins.c for the target board:

  • MP_QSTR_TX
  • MP_QSTR_RX

Boards that have support have the following in mpconfigboard.h:

  • #define DEFAULT_UART_BUS_RX
  • #define DEFAULT_UART_BUS_TX

Changing these values will change the default UART pins.

Supported Boards:

  • (All expect pirkey, ugame10)

Not Supported:

  • pirkey
  • ugame

@matt-land matt-land changed the title Feature default UART (serial) Feature: default UART (serial) May 17, 2018
tannewt
tannewt approved these changes May 17, 2018
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@tannewt tannewt merged commit 1eb412b into adafruit:master May 17, 2018
@dhalbert dhalbert mentioned this pull request May 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-land @tannewt