Temporarily disable settable pystack for esp32s3 & esp32c3.

[bill88t]

For more details please refer to #7643.
I'm pretty sure I didn't forget any boards.

This will be reverted once the proper fix is found.

[tannewt]

Why do you need to undef this?

[bill88t]

It's already defined up in py/circuitpy_mpconfig.h. Without the undef it errors out.

[dhalbert]

We try not to test on defined/undefined. We use #if SOME_FLAG to test, and throw warnings if SOME_FLAG is not defined.

Two things to do:

1. in circuitpy_mpconfig.h, do:

#ifndef CIRCUITPY_SETTABLE_PYSTACK
#define CIRCUITPY_SETTABLE_PYSTACK   (1)
#endif

and move it down into the conditionalized settings in that file, alphabetically.

2. Here in mpconfigport.h, do:

#if defined(CONFIG_IDF_TARGET_ESP32C3) || defined(CONFIG_IDF_TARGET_ESP32S3)
#define CIRCUITPY_SETTABLE_PYSTACK     (0)
#endif

mpconfigport.h is included before circuitpy_mpconfig.h, so circuitpy_mpconfig.h will pick up the turn-off setting to 0 and not set it to 1.

[dhalbert]

We try not to test on defined/undefined. We use #if SOME_FLAG to test, and throw warnings if SOME_FLAG is not defined.

Two things to do:

1. in circuitpy_mpconfig.h, do:

#ifndef CIRCUITPY_SETTABLE_PYSTACK
#define CIRCUITPY_SETTABLE_PYSTACK   (1)
#endif

and move it down into the conditionalized settings in that file, alphabetically.

2. Here in mpconfigport.h, do:

#if defined(CONFIG_IDF_TARGET_ESP32C3) || defined(CONFIG_IDF_TARGET_ESP32S3)
#define CIRCUITPY_SETTABLE_PYSTACK     (0)
#endif

mpconfigport.h is included before circuitpy_mpconfig.h, so circuitpy_mpconfig.h will pick up the turn-off setting to 0 and not set it to 1.

[bill88t]

circuitpy_mpconfig.h is still applied before the port's mpconfigport.h, hence this change still results in error.
I did make sure to move it down (passed #include "mpconfigboard.h"). But it still fails.

./mpconfigport.h:58: error: "CIRCUITPY_SETTABLE_PYSTACK" redefined [-Werror]
 #define CIRCUITPY_SETTABLE_PYSTACK (0)
 
In file included from ./mpconfigport.h:38,
                 from ../../py/mpconfig.h:45,
                 from ../../py/gc.h:31,
                 from ../../py/qstr.c:31:
../../py/circuitpy_mpconfig.h:544: note: this is the location of the previous definition
 #define CIRCUITPY_SETTABLE_PYSTACK (1)

[dhalbert]

mpconfigport.h is included before circuitpy_mpconfig.h, so circuitpy_mpconfig.h will pick up the turn-off setting to 0 and not set it to 1.

Sorry, this is wrong. I think it will work if you put this:

#if defined(CONFIG_IDF_TARGET_ESP32C3) || defined(CONFIG_IDF_TARGET_ESP32S3)
#define CIRCUITPY_SETTABLE_PYSTACK     (0)
#endif

above the #include "circuitpy_mpconfig.h" in mpconfigport.h. Try it locally first.

[bill88t]

Since S2 is also affected, I suggest it's best to just disable it for all esp for now.

[bill88t]

Well, since it's an optimisation bug it will be pretty soon fixed. No need for this to go through.