-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add wifi.radio.tx_power #6542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wifi.radio.tx_power #6542
Conversation
@todbot I revised the initial comment on this PR using the special syntax for closing an issue when a PR is accepted. |
Thanks! |
I actually started to work on this myself, and the get, set in Radio.c made sense. I also thought tx_power would need to go in I had no idea shared-bindings would need updating, so I'm glad you took this on, ty! |
I was also confused by no function decls in And apologies for stepping on your work on this! And thanks for the extra set of eyes. I'm always nervous about touching this repo publicly. :) |
You didn't step on me... I don't know C so it would have been a steep learning curve. Thank you again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One doc clarification requested.
This is exactly right. Another way to think about it is that the shared-bindings header declares all of the functions used by the shared-bindings implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Ready to merge when build is done.
Resolves #6540