Skip to content

fix SAMD21 PDMIn DMA event use #5484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Conversation

dhalbert
Copy link
Collaborator

No longer assumes that PDMIn is the only code using the event system. Removed some stall checking, which does not seem to be necessary. The stall loop value was also too low and was not waiting long enough.

Tested with the sound-level meter code for CPX.

@dhalbert dhalbert requested a review from tannewt October 19, 2021 17:22
tannewt
tannewt previously approved these changes Oct 19, 2021
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@dhalbert
Copy link
Collaborator Author

The failing check is just a CI network glitch.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactor! Thank you!

@tannewt tannewt merged commit cf4597c into adafruit:main Oct 20, 2021
@dhalbert dhalbert deleted the samd21-pdmin-fix branch October 20, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDMIn.record() infinite loop on SAMD21
2 participants