Skip to content

Add RunMode.UF2 and update esp32s2 run-modes #4925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2021
Merged

Add RunMode.UF2 and update esp32s2 run-modes #4925

merged 1 commit into from
Jul 19, 2021

Conversation

microdev1
Copy link
Collaborator

This PR closes #3884.

  • Adds microcontroller.RunMode.UF2
  • Adds UF2, NORMAL and BOOTLOADER run-modes to esp32s2

tannewt
tannewt previously requested changes Jun 28, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for taking a look at this! Just a couple things.

@microdev1
update run-mode
9ac607d 
- add microcontroller.RunMode.UF2
- add UF2, NORMAL and BOOTLOADER run-modes to esp32s2
@microdev1 microdev1 marked this pull request as ready for review July 17, 2021 18:39
@microdev1 microdev1 requested a review from tannewt July 17, 2021 18:39
@microdev1
Copy link
Collaborator Author

Note that the UF2 run-mode on esp32s2 is not working at the current stage... there is already an issue describing this #3813.

@hathach
Copy link
Member

hathach commented Jul 18, 2021

There is a fix for reset to uf2 for tinyuf2 due to changes to latest IDF adafruit/tinyuf2#130 . Using the latest 0.5.0 should probably work fine.

@microdev1 microdev1 linked an issue Jul 19, 2021 that may be closed by this pull request
ESP32S2: UF2 RunMode is not working #3813
Closed
@microdev1
Copy link
Collaborator Author

@hathach Thanks for dropping by and notifying about that change.
I tested with TinyUF2 0.5.0 on my microS2 and it works like a charm!

@microdev1 microdev1 linked an issue Jul 19, 2021 that may be closed by this pull request
ESP2S2: Resetting either programmatically or via watchdog causes device to go into SAFE_MODE #3988
Closed
dhalbert
dhalbert approved these changes Jul 19, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @microdev1 and @hathach!

@dhalbert dhalbert dismissed tannewt’s stale review July 19, 2021 20:37

requested changes addressed

@dhalbert dhalbert merged commit d2f2afe into adafruit:main Jul 19, 2021
@hathach
Copy link
Member

hathach commented Jul 19, 2021

No problems, I am glad that helps

@microdev1 microdev1 deleted the update-run-mode branch July 23, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

@tannewt tannewt Awaiting requested review from tannewt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@microdev1 @hathach @tannewt @dhalbert