Skip to content

Do USB init even in safe mode #4730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2021
Merged

Do USB init even in safe mode #4730

merged 1 commit into from
May 10, 2021

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented May 8, 2021 •
edited
Loading

Fixes #4728.

Tested on a Trinket M0. @Neradoc Could you test if you have time?

Still need to fix other issues.

@Neradoc
Copy link

Neradoc commented May 8, 2021

Does what it says. 👍
Tested on a Trinket, QT PY Haxpress, Feather M4, pico.

@dhalbert dhalbert requested review from jepler and tannewt May 8, 2021 23:44
tannewt
tannewt approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@tannewt tannewt merged commit 51120a9 into adafruit:main May 10, 2021
@dhalbert dhalbert deleted the fix-usb-safe-mode branch May 10, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

@jepler jepler Awaiting requested review from jepler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

board disappears when in safe mode
3 participants
@dhalbert @Neradoc @tannewt