Change the first byte of CircuitPython 'mpy' files to "C" #4713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. and also distinguish CircuitPython better in `mpy-cross --version`
dhalbert
approved these changes
May 6, 2021
|
Oh shoot, thanks for catching this! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. and also distinguish CircuitPython better in
mpy-cross --versionIn #4693, we allocated some flag bits differently than MicroPython (in order to fully distinguish async functions from generators). This makes our
.mpyfiles incompatible with ones generated from any version of MP.Change our first mpy signature byte to 'C' to distinguish us from MicroPython which uses 'M'.
Hopefully this will be the last bytecode incompatibility before 7.0. 😜