Skip to content

New board: Fluff M0 Headless #4285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

deshipu
Copy link

@deshipu deshipu commented Feb 27, 2021

This is the same as Fluff M0, but disables the MSC, CDC and MIDI USB
endpoints. This is useful for devices like keyboards or mice running
CircuitPython, once we are happy with their code and don't want to
change it anymore.

I'm adding this board mostly so that we have a test for this case.

This is the same as Fluff M0, but disables the MSC, CDC and MIDI USB
endpoints. This is useful for devices like keyboards or mice running
CircuitPython, once we are happy with their code and don't want to
change it anymore.

I'm adding this board mostly so that we have a test for this case.
@ajs256
Copy link

ajs256 commented Feb 27, 2021

Looks like you forgot to add it to build.yml.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the headless board to tools/ci_check_duplicate_usb_vid_pid.py; it's complaining right now that the two Fluff boards have the same PID.

@tannewt
Copy link
Member

tannewt commented Mar 2, 2021

Are we sure we want this? This seems like a very board-specific change for a non-board specific problem. @dhalbert was recently talking about a way to disable the pieces of a USB descriptor from boot.py.

@deshipu deshipu force-pushed the fluff-m0-headless branch from 80b3f17 to 9b3fc83 Compare March 2, 2021 10:11
@deshipu
Copy link
Author

deshipu commented Mar 3, 2021

There is no telling when the dynamic USB descriptors will be implemented — we have been talking about them for years, and they are not a very important feature, but there are few people with the expertise. On the other hand, I have a number of devices that rely on this, and that got broken with #4283 — if we had this earlier, we would have caught the problem. I suppose it's a trade-off between build times and coverage.

By the way, I did this with Fluff M0, because that's what I'm using, but I would be happy to do it with any other board instead, as long as we exercise the case with MSC disabled.

@dhalbert
Copy link
Collaborator

dhalbert commented Mar 3, 2021

I think there are two reasons to have this:

  1. You have a project used by multiple people that depends on no MSC (like the stenotype project I think you mentioned), and it is impractical to supply a custom build for that. That is what I though the original motivation was.
  2. We need to test whether various compilation flags actually work or not. This particular flag is one of many. I could imagine adding a test build that compiles a single language and board multiple ways. I would do it different than adding a new board, because we don't need to generate builds for multiple translations to test a flag like this.

@deshipu
Copy link
Author

deshipu commented Mar 3, 2021

Since I'm not actually selling those projects yet, I am mostly concerned with 2. If you think there is a better way to test this, please feel free to close this.

@dhalbert
Copy link
Collaborator

dhalbert commented Mar 3, 2021

OK, I will close. I think the point you are bringing up is well-taken: we don't have a testing story for things like this, and we need to think about it in the long run.

@dhalbert dhalbert closed this Mar 3, 2021
@tannewt
Copy link
Member

tannewt commented Mar 3, 2021

Do we have an issue to add these tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants