-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New board: Fluff M0 Headless #4285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is the same as Fluff M0, but disables the MSC, CDC and MIDI USB endpoints. This is useful for devices like keyboards or mice running CircuitPython, once we are happy with their code and don't want to change it anymore. I'm adding this board mostly so that we have a test for this case.
Looks like you forgot to add it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the headless
board to tools/ci_check_duplicate_usb_vid_pid.py
; it's complaining right now that the two Fluff boards have the same PID.
Are we sure we want this? This seems like a very board-specific change for a non-board specific problem. @dhalbert was recently talking about a way to disable the pieces of a USB descriptor from boot.py. |
80b3f17
to
9b3fc83
Compare
There is no telling when the dynamic USB descriptors will be implemented — we have been talking about them for years, and they are not a very important feature, but there are few people with the expertise. On the other hand, I have a number of devices that rely on this, and that got broken with #4283 — if we had this earlier, we would have caught the problem. I suppose it's a trade-off between build times and coverage. By the way, I did this with Fluff M0, because that's what I'm using, but I would be happy to do it with any other board instead, as long as we exercise the case with MSC disabled. |
I think there are two reasons to have this:
|
Since I'm not actually selling those projects yet, I am mostly concerned with 2. If you think there is a better way to test this, please feel free to close this. |
OK, I will close. I think the point you are bringing up is well-taken: we don't have a testing story for things like this, and we need to think about it in the long run. |
Do we have an issue to add these tests? |
This is the same as Fluff M0, but disables the MSC, CDC and MIDI USB
endpoints. This is useful for devices like keyboards or mice running
CircuitPython, once we are happy with their code and don't want to
change it anymore.
I'm adding this board mostly so that we have a test for this case.