Skip to content

Support for OTA update #3812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Dec 22, 2020
Merged

Support for OTA update #3812

merged 14 commits into from
Dec 22, 2020

Conversation

microdev1
Copy link
Collaborator

@microdev1 microdev1 commented Dec 9, 2020 •
edited
Loading

This PR implements CircuitPython OTA update!

Port(s) supported: (as of this PR)

  • esp32s2

To-do:

  • Error message clean-up.
  • Finalize OTA module and add docs.
  • Add ability to flash in continuous/discontinuous chunks.

Note: more info leading to this PR can be found at issue #3777.

@tannewt tannewt self-requested a review December 9, 2020 19:38
@tannewt tannewt added circuitpython api enhancement espressif applies to multiple Espressif chips labels Dec 9, 2020
tannewt
tannewt requested changes Dec 9, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need more details in the comments. Otherwise the simple API looks good! Thanks!

tannewt
tannewt reviewed Dec 11, 2020
View reviewed changes
@microdev1 microdev1 marked this pull request as ready for review December 12, 2020 00:05
@microdev1 microdev1 requested a review from tannewt December 12, 2020 00:05
tannewt
tannewt requested changes Dec 15, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the additional comments! Just a couple other comments.

@microdev1 microdev1 requested a review from tannewt December 17, 2020 19:15
tannewt
tannewt approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@tannewt tannewt merged commit 6347a3f into adafruit:main Dec 22, 2020
@microdev1 microdev1 deleted the ota-s2 branch December 26, 2020 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert left review comments

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
circuitpython api enhancement espressif applies to multiple Espressif chips
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@microdev1 @tannewt @dhalbert