Skip to content

esp32s2: Update esp-idf submodule to include fix for #3424 #3691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

jepler
Copy link

@jepler jepler commented Nov 14, 2020

This re-points the submodule to my personal fork of esp-idf. Users may need to git submodule sync in their existing trees when
this change occurs.

Adds just the following commit in esp-idf:

esp_crt_bundle: Allow verify_callback to correct BADCERT_BAD_MD

This change has also been submitted upstream at esp-idf: espressif/esp-idf#6117

This re-points the submodule to my personal fork of esp-idf.
Users may need to `git submodule sync` in their existing trees when
this change occurs.

Adds just the following commit in esp-idf:
  > esp_crt_bundle: Allow verify_callback to correct BADCERT_BAD_MD
@jepler jepler linked an issue Nov 14, 2020 that may be closed by this pull request
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can connect no problem to thingspeak and adafruit.io and get data from em!

@jerryneedell
Copy link
Collaborator

I tested this PR on a MAGTAG and now now also able to access "CheerLights: via the thingspeak https URL.
I did have to revert to an older version of the Requests Library to avoid the new issue with "split" adafruit/Adafruit_CircuitPython_Requests#52
It works with the requests library from the 11/07/2020 bundle,

@jerryneedell
Copy link
Collaborator

Is this likely to be merged into main or will you wait for the esp-idf to accept it upstream? Just curious.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging it now. :-)

@tannewt tannewt merged commit f8eed1f into adafruit:main Nov 16, 2020
@jepler jepler deleted the issue-3424 branch November 3, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

certificate chain verification bug in esp-idf
4 participants