improve USB CDC disconnect/reconnect checking #3624
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3588.
Check for DTR by querying
tud_cdc_get_line_state()
, and check fortud_usb_ready()
. One doesn't need to save state in callbacks this way.Tested two ways:
supervisor.runtime.serial_available
becomes falase. After wakeup, the serial connection is restored, andsupervisor.runtime.serial_available
isTrue
. Interrupting the running program with ctrl-c works properly, and one can get to the REPL.I did try the data/charge-only cable with a switch, but it gives peculiar results. It detects as disconnected and then reconnected when switched, I think because some resistors are added to the data lines to mark the cable as charge-only.