mimxrt10xx: Implement pin claiming, pin reset, and pin protections #2898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
May 15, 2020
arturo182
requested changes
May 16, 2020
|
@tannewt @arturo182 issues reworked, this should be good for re-review. |
arturo182
approved these changes
May 19, 2020
tannewt
approved these changes
May 20, 2020
hierophect
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the Microcontroller/Pin module to allow pin objects to be claimed and reset in the context of a python program. Claiming prevents pins that have previously been used for a peripheral instance from being used again without a de-init, and resetting returns pins to their startup state. All pins except those in the never_reset array are automatically reset at startup and soft reboots.
This ended up being a little trickier than it usually is for other ports, since the i.MX does not have a pin reset function in the SDK, and has unique reset values for many pins. Additionally, it is more difficult to iterate through pins on the i.MX since GPIO banks are frequently left incomplete, with fewer than 32 pins included per bank. I resolved this by adding an iterable pin array and some new values to the pin object, but I'm open to any and all suggestions on approach!
This makes some assumptions about what pins to include in never_reset for the feathers, since I don't have their schematics - @arturo182 and @tannewt, please double check these if you can to ensure my guesses are correct.
Tested on 1010 EVK, still double checking the 1020 and 1060 so should not be merged until those are done.
resolves #2486
resolves #2481
resolves #2479