Skip to content

Renumber endpoints for only chosen USB interfaces; fix HID report ids #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Sep 9, 2019

  • Endpoint renumbering was done over all the possible USB devices, not the selected ones.
  • Handling of no report ID when only one HID devices was incorrect.
  • Reordered where to put HID in descriptor (just for consistency).

@dhalbert dhalbert requested a review from hierophect September 9, 2019 19:14
@hierophect
Copy link
Collaborator

While it looks conceptually fine to me I'm not an experienced enough Python coder to notice issues with the implementation. I'd recommend having at least one other person check it out.

Copy link
Collaborator

@hierophect hierophect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually fine but I'd double check with a python person.

@dhalbert
Copy link
Collaborator Author

dhalbert commented Sep 9, 2019

@hierophect can you test it on STM32F412 with reduced USB devices to see if the Windows enumeration problem crops up? I can give you a build if you want.

@hierophect
Copy link
Collaborator

@dhalbert sure can you pass me a binary?

@dhalbert
Copy link
Collaborator Author

dhalbert commented Sep 9, 2019

I tested this on a '412 board, using the commit from #2132 just before this commit d8251ae. Works fine on Linux and Windows.

@dhalbert dhalbert merged commit 4282ff4 into adafruit:master Sep 9, 2019
@dhalbert dhalbert deleted the usb-selection-fix branch September 9, 2019 22:18
@ladyada
Copy link
Member

ladyada commented Sep 9, 2019

thank you!

@dhalbert
Copy link
Collaborator Author

Fixes bugs in #2116.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants