Skip to content

Fix crash in internal filesystem on nrf #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2019
Merged

Fix crash in internal filesystem on nrf #1870

merged 1 commit into from
May 8, 2019

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented May 8, 2019

Fixes #1842

@tannewt tannewt added this to the 4.0.0 - Bluetooth milestone May 8, 2019
jerryneedell
jerryneedell approved these changes May 8, 2019
View reviewed changes
Copy link
Collaborator

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on pca10059,makerdiary_nrf52840_mdk_usb_dongle,sparkfun_nrf52840_mini and on feather_nrf52840_express. All boot normally.

dhalbert
dhalbert approved these changes May 8, 2019
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@nickzoic
Copy link

nickzoic commented May 8, 2019

(I can have a look tomorrow (Friday GMT+10))

@dhalbert dhalbert merged commit 019254a into adafruit:master May 8, 2019
@dhalbert dhalbert mentioned this pull request May 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

@jerryneedell jerryneedell jerryneedell approved these changes

@nickzoic nickzoic Awaiting requested review from nickzoic

Assignees
No one assigned
Labels
bug crash nordic
Projects
None yet
Milestone
4.0.0 - Bluetooth
Development

Successfully merging this pull request may close these issues.

some nrf52840 boards boot to safe mode with rc.1
4 participants
@tannewt @nickzoic @dhalbert @jerryneedell