Skip to content

Turn on frequencyio only on CIRCUITPY_FULL_BUILD #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2019

Conversation

dhalbert
Copy link
Collaborator

frequencyio is too large to fit on some small builds due to language string size. Turn it off for small builds.

@dhalbert dhalbert requested a review from tannewt March 27, 2019 20:59
@sommersoft
Copy link

@dhalbert just to note, I went with explicit CIRCUITPY_FREQUENCYIO = 0 so that SAMD21 wouldn't include it (I did miss setting it in CatWAN). I still need to go back and test the SAMD21 code that is left in FrequencyIn as an optional build. But, if a future SAMD21 port doesn't explicitly exclude frequencyio, and uses the full build, it will be included.

@dhalbert
Copy link
Collaborator Author

I can turn it off explicitly in all SAMD21 builds now. I can add a new commit to this PR. Does that make sense?

@dhalbert
Copy link
Collaborator Author

I would make the changes in mpconfigport.mk and check for SAMD21.

@sommersoft
Copy link

I would make the changes in mpconfigport.mk and check for SAMD21.

why didn't I think of that. haha

@dhalbert
Copy link
Collaborator Author

dhalbert commented Mar 27, 2019

CIRCUITPY_FREQUENCYIO = 0 is left in on on samd21 mpconfigboard.mk files because those builds need it off no matter what, for space reasons, even it becomes usable on samd21.

@dhalbert
Copy link
Collaborator Author

@sommersoft @tannewt this has now passed travis too.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@tannewt tannewt merged commit fd134df into adafruit:master Mar 28, 2019
@dhalbert dhalbert deleted the frequencyio-full-builds branch May 28, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants