Skip to content

TileGrid: pixel_shader is not always a Palette #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2019
Merged

TileGrid: pixel_shader is not always a Palette #1714

merged 1 commit into from
Mar 27, 2019

Conversation

dhalbert
Copy link
Collaborator

shared-module/TileGrid.c didn't handle some cases where the pixel_shader might be a ColorConverter instead of a Palette. Fixes #1695.

@dhalbert dhalbert requested a review from tannewt March 27, 2019 14:57
@dhalbert dhalbert changed the title TileGrid: pixel_shader is not always a palette TileGrid: pixel_shader is not always a Palette Mar 27, 2019
tannewt
tannewt approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W00t! Thank you!

@tannewt tannewt merged commit 94822ee into adafruit:master Mar 27, 2019
@dhalbert dhalbert deleted the pixel-shader-bug branch March 27, 2019 17:58
@dhalbert dhalbert mentioned this pull request Mar 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhalbert @tannewt