Skip to content

nrf: fix internal flash writes #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2019

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Mar 18, 2019

Still thinking a bit about when else to flush the cache, maybe using auto-reload timer (even if we are not running a code.py). PR for now is for testing -- don't merge quite yet.

Fixes #1654.

@dhalbert
Copy link
Collaborator Author

@jerryneedell @uhreber This PR has an additional filesystem flush beyond the .uf2's I gave you. @jerryneedell, this may fix the "missing file" you mentioned at the end of this comment.

@jerryneedell
Copy link
Collaborator

downloaded and tested on PCA10059 -- ran same sequence as before:
erased FS
reloaded libs
reloaded ble_uart_echo_test
this time all files were present

ran ble_uart_echo_test
copied 5Kbyte file to CIRCUITPY a few times
no issues

Copy link
Collaborator

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on PCA10059 - unable to reproduce any of the FS issues I reported previously.

@dhalbert dhalbert merged commit b4b8ffa into adafruit:master Mar 18, 2019
@dhalbert dhalbert deleted the nrf-internal-flash-fixes branch March 18, 2019 14:41
@dhalbert dhalbert mentioned this pull request Apr 13, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

file system issues on pca10059
2 participants