Don't wait for display frame if interrupt pending #1604
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common_hal_displayio_display_wait_for_frame()
would call the background tasks over and over. If a reload was pending,displayio_refresh_displays()
would stop refreshing, butcommon_hal_displayio_display_wait_for_frame()
didn't know that.The effect was that writes to CIRCUITPY would cause the board to apparently freeze (because the display was frozen). It was really cycling in the background task, never to return.
Details:
common_hal_displayio_display_wait_for_frame()
.displayio_refresh_displays()
:KeyboardInterrupt
immediately (otherwise sometimes two ctrl-C's were needed)ReloadException
if it was already raised.I believe this fixes freezes seen by @ladyada, who will test in a few days.
This may or may not have something to do with #1577.