Skip to content

add pin def for BAT #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2018
Merged

add pin def for BAT #1272

merged 3 commits into from
Oct 17, 2018

Conversation

sajattack
Copy link

Fixes #1149

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

I know BAT is sometimes on the silkscreen but I'd prefer BATTERY. Truncations like BAT are much more difficult for non-native english speakers to understand/look up.

@dhalbert
Copy link
Collaborator

Build errors on itsy_bitsy_m4_express: https://travis-ci.org/adafruit/circuitpython/jobs/441508064#L1143

@sajattack
Copy link
Author

Ok. I looked at the schematic and it looks like PB01 was the correct pin connected to the BAT pin. Do I have to define it somehow?

@dhalbert
Copy link
Collaborator

@sajattack That schematic is for the Feather M4, which uses the 64-pin SAMD51J19. The Itsy Bitsy uses the 48-pin SAMD51G19. I don't see any voltag monitoring stuff on the Itsy M4. Schematic here: https://learn.adafruit.com/introducing-adafruit-itsybitsy-m4/downloads.

Neither the Itsy M0 nor M4 have a voltage divider for monitoring. So remove the BATTERY pin from the Itsy M0 as well, in your changes.

@tannewt
Copy link
Member

tannewt commented Oct 17, 2018

Thank you!

@tannewt tannewt merged commit b436666 into adafruit:master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants