Skip to content

Fix crash due to unsigned index and 0 boundary loop. #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2018
Merged

Fix crash due to unsigned index and 0 boundary loop. #1119

merged 1 commit into from
Aug 16, 2018

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Aug 16, 2018

No description provided.

@tannewt tannewt added this to the 4.0 Alpha milestone Aug 16, 2018
@ladyada
Copy link
Member

ladyada commented Aug 16, 2018

heyhey scott - i can review but dont know much about the bug to really know what this is fixin!

tannewt
tannewt commented Aug 16, 2018
View reviewed changes
Copy link
Member Author

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes a case with the loop on line 68 where index is 0 and wrapped around causing the loop to run a second time. It manifested as a hard fault due to incorrect memset bounds.

@ladyada
Copy link
Member

ladyada commented Aug 16, 2018

got it! yeah thats annoying :/

@ladyada
Copy link
Member

ladyada commented Aug 16, 2018

reviewed, merge away!

@tannewt tannewt merged commit 92ed5d7 into adafruit:master Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

Assignees

@ladyada ladyada

Labels
bug crash supervisor
Projects
None yet
Milestone
4.0 Alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@tannewt @ladyada