Nrf52840 usb hid #1074

hathach · 2018-07-31T18:12:43Z

Implement USB HID #1009 with following devices: keyboard, mouse, consumer control, gamepad, sys control. Note: Digitizer is not supported yet, since I am new to this device and didn't know how to test with.
Fix an issue when eject/safely remove msc (START_STOP_UNIT command not handle previously) https://github.com/hathach/circuitpython/blob/nrf52840_usb_hid/ports/nrf/usb/usb_msc_flash.c#L74 . Also set sense key to invalid command for unknown cmd.
Added walkaround to use common lib/utils/interrupt_char.c https://github.com/hathach/circuitpython/blob/nrf52840_usb_hid/ports/nrf/usb/usb.c#L90
better function description here and there
enable MICROPY_PY_ARRAY_SLICE_ASSIGN & MICROPY_PY_BUILTINS_SLICE_ATTRS ( thanks to @dhalbert )

PS: tinyusb submodule needs to be updated

compiled with undefined ref

jerryneedell · 2018-08-01T02:09:23Z

FYI - I pulled this PR and built an image for the pca10056 board. It seems ok for basic operation - I was able to mount an SD Card (SPI ) and run a BLE scan.
Note: the BLE scan only shows one record, but I think this is something that @arturo182 is aware of and already has a fix for.
I have not tried any of the HID functions.

jerryneedell · 2018-08-01T02:11:14Z

I did try mounting/unmounting CIRCUITPY a few times - no errors ...yet!

hathach · 2018-08-01T02:11:33Z

@jerryneedell you could try hid mouse, it is easiest thing to test with
https://circuitpython.readthedocs.io/projects/hid/en/latest/index.html

copy adafruit_hid from bundle to lib/ folder and type these into REPL

from adafruit_hid.mouse import Mouse

m = Mouse()

# Click the left mouse button.
m.click(Mouse.LEFT_BUTTON)

# Move the mouse diagonally to the upper left.
m.move(-100, -100, 0)

jerryneedell · 2018-08-01T02:16:12Z

@hathach I tried it and it works!!

dhalbert · 2018-08-01T04:11:28Z

ports/nrf/common-hal/usb_hid/Device.c

+    while ( (ticks_ms < end_ticks) && !tud_hid_generic_ready() ) { }
+
+    if ( !tud_hid_generic_ready() ) {
+        mp_raise_msg(&mp_type_OSError,  "USB Busy");


You can use mp_raise_OSError("USB Busy") here and similarly elsewhere. Easier to read and saves a few bytes.

mp_raise_OSError takes int parameter, since usb does have its error enu, what should be the value for these in the list
https://github.com/adafruit/circuitpython/blob/master/py/mperrno.h

You're right, never mind, I forgot that it takes only an integer arg.

OK, nrf52 still got plenty of space left anyway :D

dhalbert · 2018-08-01T04:15:08Z

ports/nrf/usb/usb_desc.c

+    TUD_DESC_STRCONV('A','d','a','f','r','u','i','t',' ','I','n','d','u','s','t','r','i','e','s'),
+
+    // 2 Product
+    TUD_DESC_STRCONV('C','i','r','c','u','i','t','P','Y',' ','n','R','F','5','2'),


Trivial, but make these lowercase y. CircuitPy instead of CircuitPY.

dhalbert · 2018-08-01T04:17:19Z

ports/nrf/usb/usb_msc_flash.c

-            // SCSI output
-        }
-    }
+    if ( resplen > bufsize ) resplen = bufsize;


Use curly braces on all ifs, even one-line ones. Thanks. We're trying to keep to that style.

dhalbert

Only minor changes. Looks great! TinyUSB looks very clean :).

I tested mouse, keyboard, consumer control, and gamepad.

Don't worry about digitizer. I could not set up a digitizer-style device that worked across Windows, Linux, and Mac. I left the report descriptor in just to remember what I'd done.

ladyada · 2018-08-01T04:32:48Z

nice work, thach! i hope to get back to testing nrf52840 again soon!

dhalbert

Great! Thanks!

hathach · 2018-08-01T04:35:06Z

ports/nrf/common-hal/usb_hid/Device.h

+#define USB_HID_DEVICE_CONSUMER         1
+#define USB_HID_DEVICE_SYS_CONTROL      1
+#define USB_HID_DEVICE_GAMEPAD          1
+#define USB_HID_DEVICE_DIGITIZER        0 // not supported yet


@dhalbert list of enabled hid devices is here, just in case you wan to disable any of these.

hathach · 2018-08-01T04:35:46Z

@dhalbert thanks, I tried to get all the ugly part inside the tinyusb stack itself :D

hathach · 2018-08-01T04:39:43Z

@ladyada thanks, hopefully you won't find out too many bugs :D

dhalbert · 2018-09-17T11:36:32Z

Fixes #1008 as well (and maybe also via other PRs).

dhalbert · 2018-09-17T11:37:47Z

Fixes #1009.

hathach added 16 commits July 26, 2018 17:16

update tusb lib

5bdf409

add usb msc callback description

e86f7d0

house keeping

21339c4

adding usb_hid

368d597

compiled with undefined ref

update tinyusb, set scsi sense key for unsupported commands

ae783b0

workaround to use lib/utils/interrupt_char.c

221d54a

hid keyboard and mouse work well

d15caf0

add usb_desc, disable tinyusb stack CFG_TUD_DESC_AUTO

27b2a9f

improve usb hid

fd661c1

usb hid consumer control works

ef58ada

add usb hid syscontrol

2c85f42

all hid devices seems to be ok

05139e2

add hid keyboard LED indicator stub

4bece22

enable MICROPY_PY_ARRAY_SLICE_ASSIGN, MICROPY_PY_BUILTINS_SLICE_ATTRS

85bd46a

update tinyusb

20c25f6

Merge branch 'master' into nrf52840_usb_hid

1e524f1

hathach requested review from tannewt, arturo182 and dhalbert July 31, 2018 18:12

tannewt removed their request for review July 31, 2018 18:39

hathach added 3 commits August 1, 2018 08:20

clean up

6ddd858

clean up

bac233e

more clean up

2006692

dhalbert reviewed Aug 1, 2018

View reviewed changes

dhalbert requested changes Aug 1, 2018

View reviewed changes

PR review clean up

592c190

dhalbert approved these changes Aug 1, 2018

View reviewed changes

hathach commented Aug 1, 2018

View reviewed changes

dhalbert merged commit 65bd07b into adafruit:master Aug 1, 2018

hathach deleted the nrf52840_usb_hid branch August 22, 2018 08:26

dhalbert mentioned this pull request Sep 17, 2018

USB mass storage #1008

Closed

dhalbert mentioned this pull request Sep 17, 2018

USB HID #1009

Closed

Nrf52840 usb hid #1074

Nrf52840 usb hid #1074

Uh oh!

Conversation

hathach commented Jul 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jerryneedell commented Aug 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jerryneedell commented Aug 1, 2018

Uh oh!

hathach commented Aug 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jerryneedell commented Aug 1, 2018

Uh oh!

dhalbert Aug 1, 2018

Choose a reason for hiding this comment

Uh oh!

hathach Aug 1, 2018

Choose a reason for hiding this comment

Uh oh!

dhalbert Aug 1, 2018

Choose a reason for hiding this comment

Uh oh!

hathach Aug 1, 2018

Choose a reason for hiding this comment

Uh oh!

dhalbert Aug 1, 2018

Choose a reason for hiding this comment

Uh oh!

dhalbert Aug 1, 2018

Choose a reason for hiding this comment

Uh oh!

dhalbert left a comment

Choose a reason for hiding this comment

Uh oh!

ladyada commented Aug 1, 2018

Uh oh!

dhalbert left a comment

Choose a reason for hiding this comment

Uh oh!

hathach Aug 1, 2018

Choose a reason for hiding this comment

Uh oh!

hathach commented Aug 1, 2018

Uh oh!

hathach commented Aug 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhalbert commented Sep 17, 2018

Uh oh!

dhalbert commented Sep 17, 2018

Uh oh!

Uh oh!

hathach commented Jul 31, 2018 •

edited

Loading

jerryneedell commented Aug 1, 2018 •

edited

Loading

hathach commented Aug 1, 2018 •

edited

Loading

hathach commented Aug 1, 2018 •

edited

Loading