Skip to content

PyPortal TFT left hand edge getting cutoff when using case with 8.0.0 release #7562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
caternuson opened this issue Feb 9, 2023 · 4 comments · Fixed by #7880
Closed

PyPortal TFT left hand edge getting cutoff when using case with 8.0.0 release #7562

caternuson opened this issue Feb 9, 2023 · 4 comments · Fixed by #7880
Assignees
@tannewt
Labels
bug displayio
Milestone
8.1.0

Comments

@caternuson
Copy link

CircuitPython version

Adafruit CircuitPython 8.0.0 on 2023-02-06; Adafruit PyPortal with samd51j20

Code/REPL

n/a

Behavior

n/a

Description

Left hand edge of display gets cutoff when using the PyPortal with the Desktop Stand case:
https://www.adafruit.com/product/4146

Looks OK with 7.3.3.

Additional information

See related forum thread here:
https://forums.adafruit.com/viewtopic.php?p=959876
@caternuson caternuson added the bug label Feb 9, 2023
@dhalbert
Copy link
Collaborator

dhalbert commented Feb 9, 2023

This may be due to status bar (title bar) changes, maybe in #6473?

@dhalbert dhalbert added this to the 8.x.x milestone Feb 9, 2023
@tannewt
Copy link
Member

tannewt commented Feb 10, 2023

This was a deliberate change I made. We used to leave a blank column below blinka because the terminal's top left corner was to the right of it. Now, with 8.0, the title bar terminal is to the right of blinka and the regular terminal can now be positioned below it.

I don't know what we'd want to change in CP for this.

@dhalbert
Copy link
Collaborator

Can the terminal TileGrid (is it a TileGrid), just be redone to be narrower and its origin repositioned? This could be done for the PyPortal in general, or we could offer a software solution (in boot.py or code.py?) for those using the case.

And maybe we should respin the case design.

@tannewt
Copy link
Member

tannewt commented Feb 13, 2023

Ya, we use TileGrid for it and we could resize it. But, I like that it can show more text than if it is scooted over.

@tannewt tannewt modified the milestones: 8.x.x, 8.1.0 Apr 14, 2023
@tannewt tannewt mentioned this issue Apr 19, 2023
Merged
dhalbert pushed a commit that referenced this issue Apr 20, 2023
@tannewt
Add PicoDVI support
66edcf5 
PicoDVI in CP support 640x480 and 800x480 on Feather DVI, Pico and
Pico W. 1 and 2 bit grayscale are full resolution. 8 and 16 bit
color are half resolution.

Memory layout is modified to give the top most 4k of ram to the
second core. Its MPU is used to prevent flash access after startup.

The port saved word is moved to a watchdog scratch register so that
it doesn't get overwritten by other things in RAM.

Right align status bar and scroll area. This normally gives a few
pixels of padding on the left hand side and improves the odds it is
readable in a case. Fixes #7562

Fixes c stack checking. The length was correct but the top was being
set to the current stack pointer instead of the correct top.
Fixes #7643

This makes Bitmap subscr raise IndexError instead of ValueError
when the index arguments are wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tannewt tannewt

Labels
bug displayio
Projects
None yet
Milestone
8.1.0
Development

Successfully merging a pull request may close this issue.

Add PicoDVI support tannewt/circuitpython
3 participants
@tannewt @dhalbert @caternuson