-
Notifications
You must be signed in to change notification settings - Fork 71
Fix ci build with esp32s2 boards #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
use folder path i.e example dir instead of path to .ino file
@hathach Enabling |
@brentru im workin on this right now - i was getting false positives! |
|
@brentru ok try now, took me a few tries to figure it out |
haha its ok - you can uncomment the print-outs when you work on it next, i think it can be made to work |
@hathach Were S2 builds just taking a long time, or never completing? |
It never complete before, now it got time out (60 seconds), I tried with 600 seconds, still time out. So I guess it won't ever complete. Will do more in-depth test later on. |
@hathach Ok - I had the same behavior. The script does compile and generate a Uf2 for s2 with arduino-cli when invoked from my computer, not sure why it's running indefinitely on the CI. Ping me when you've tested it in-depth and I'll see if it passes with WipperSnapper. |
@brentru sure, I will tag you to the PR, if I could mange to fix it :) |
shell=True
in popen. ci built with this PR https://github.com/adafruit/Adafruit_TinyUSB_Arduino/runs/3744226543?check_suite_focus=true#step:6:33folderpath
i.e example directory instead of path to .ino file. Since it is the preferred input of arduino-cli@ladyada
def test_examples_in_learningrepo(folderpath):
isn't got updated, since it seems not to be used anymore. Should we remove it ?