Socket improvements

[xorbit]

• Fixed socket_available to just report and not flush available UDP
  data when calling multiple times.
• Fixed socket __exit__ to only disconnect if a TCP (stream) socket.
• Connect can now accept domain names like CPython versus only IP
  addresses.
• Added socket send_to, recvfrom, recv_into, recvfrom_into
  methods for better compatibility with CPython socket.
• Simplified recv and readline socket methods due to
  available doing the right thing for both TCP and UDP.
• Reformatting to make black happy.
• Changes made and tested to make generic socket NTP implementation work:
  https://github.com/askpatrickw/Adafruit_CircuitPython_NTP/blob/raw_ntp/adafruit_ntp.py

[xorbit]

You know, this CI is more trouble than it's worth. I check my code with black on my machine yet the CI back seems to have a different idea of what it should look like but doesn't tell me what.

[tannewt]

@xorbit I recommend setting up pre-commit if you haven't already. It should manage black and the other checks the CI does. Instructions are here: https://pre-commit.com/#installation

[xorbit]

Thanks for that tip @tannewt !
With help I may learn all these software development tricks yet. I try to keep myself on the hardware side of things mostly but sometimes it's unavoidable to deal with software too.

With pre-commit, black undid a change my system-wide black made yesterday. 😂

[tannewt]

Yup! Sorry about that. We've been meaning to add the pre-commit recommendation to the guides but I'm not sure we have yet.

[tannewt]

(Will let Brent review and test.) Thanks for the PR! Sorry for the frustrating CI.

[brentru]

@xorbit I tried wiznet5k_simpleserver.py on my board (with DHCP disabled) and was unable to see a response echo'd back after I ran:
echo -n "hello featherwing" | nc 192.168.10.1 50007

However, I used the wsgi server in the README and had no issues connecting. Same with the simpletest.

Any ideas?

[xorbit]

@xorbit I tried wiznet5k_simpleserver.py on my board (with DHCP disabled) and was unable to see a response echo'd back after I ran:
echo -n "hello featherwing" | nc 192.168.10.1 50007

However, I used the wsgi server in the README and had no issues connecting. Same with the simpletest.

Any ideas?

Odd. I tried it and it seems to work for me. The only difference is that I had DHCP. See this REPL log with debug enabled:

>>> while True:
...     conn, addr = server.accept()
...     print("Connection from {} port {}".format(addr[0], addr[1]))
...     with conn:
...         data= conn.recv()
...         print (data)
...         conn.send(data)
... 
*** Get socket
Allocated socket #1
* Dest is (192.168.1.109, 32896), Next listen socknum is #1
*** Get socket
Allocated socket #1
* Listening on port=50007, ip=192.168.1.135
*** Opening socket 1
* Opening W5k Socket, protocol=33
Connection from 192.168.1.109 port 32896
* socket_available called with protocol 33
Bytes avail. on sock:  17
         * Processing 17 bytes of data
* socket_available called with protocol 33
b'hello featherwing'
*** Disconnecting socket #0
*** Closing socket #0
*** Get socket
Allocated socket #0
* Dest is (192.168.1.109, 32896), Next listen socknum is #0
*** Get socket
Allocated socket #0
* Listening on port=50007, ip=192.168.1.135
*** Opening socket 0
* Opening W5k Socket, protocol=33
Connection from 192.168.1.109 port 32896
* socket_available called with protocol 33
Bytes avail. on sock:  8
         * Processing 8 bytes of data
* socket_available called with protocol 33
b'hello m4'
*** Disconnecting socket #1
*** Closing socket #1

So I wondered if it could be a difference because I was using DHCP, so I redid the test without it:

>>> socket.set_interface(eth)
>>> server = socket.socket()
*** Get socket
Allocated socket #0
>>> server.bind(("192.168.1.136", 50007))
>>> server.listen()
* Listening on port=50007, ip=192.168.1.136
*** Opening socket 0
* Opening W5k Socket, protocol=33
>>> while True:
...     conn, addr = server.accept()
...     print ("Connection from {} port {}".format(addr[0], addr[1]))
...     with conn:
...         data = conn.recv()
...         print(data)
...         conn.send(data)
... 
*** Get socket
Allocated socket #1
* Dest is (192.168.1.109, 53456), Next listen socknum is #1
*** Get socket
Allocated socket #1
* Listening on port=50007, ip=192.168.1.136
*** Opening socket 1
* Opening W5k Socket, protocol=33
Connection from 192.168.1.109 port 53456
* socket_available called with protocol 33
Bytes avail. on sock:  13
         * Processing 13 bytes of data
* socket_available called with protocol 33
b'hello m4-shim'
*** Disconnecting socket #0
*** Closing socket #0

Not sure why it's different from your test.

[brentru]

@xorbit It might be an issue with my local network. Thanks for providing hardware debug logs.