Fix SPI class with new page addressing mode option #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
approved these changes
Mar 3, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 11, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7341 to 1.0.6 from 1.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#11 from FoamyGuy/pylintrc_and_versions Updating https://github.com/adafruit/Adafruit_CircuitPython_BH1750 to 1.0.4 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_BH1750#1 from FoamyGuy/pylintrc Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X to 1.0.6 from 1.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x#17 from FoamyGuy/pylintrc Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X_RVC to 1.0.4 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x_RVC#2 from FoamyGuy/pylintrc Updating https://github.com/adafruit/Adafruit_CircuitPython_CLUE to 2.2.9 from 2.2.8: > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#40 from AlexColello/patch-2 Updating https://github.com/adafruit/Adafruit_CircuitPython_EMC2101 to 1.1.4 from 1.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#5 from FoamyGuy/pylint_to_precommit Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.6 from 3.5.5: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#124 from FoamyGuy/pylintrc > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#125 from brentru/rp2040 Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 3.0.2 from 3.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#40 from dglaude/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_LC709203F to 2.0.2 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_LC709203F#9 from FoamyGuy/pylintrc_and_versions Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.1.3 from 4.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#38 from FoamyGuy/pylintrc Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP2515 to 1.0.8 from 1.0.7: > Merge pull request adafruit/Adafruit_CircuitPython_MCP2515#8 from FoamyGuy/pylintrc_and_versions Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 2.0.5 from 2.0.4: > Re-added pylint install to build.yml > Removed pylint process from github workflow > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#27 from SAK917/master Updating https://github.com/adafruit/Adafruit_CircuitPython_MS8607 to 1.0.6 from 1.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_MS8607#6 from FoamyGuy/pylintrc Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8591 to 1.0.4 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_PCF8591#3 from FoamyGuy/pylint_ignore_imports Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.11.2 from 2.11.1: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#59 from adamcandy/fix-page-addressing-mode-spi Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.2.3 from 5.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#66 from brentru/rp2040-example > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#65 from FoamyGuy/pylintrc Updating https://github.com/adafruit/Adafruit_CircuitPython_datetime to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_datetime#3 from FoamyGuy/pylint_to_pre_commit > Merge pull request adafruit/Adafruit_CircuitPython_datetime#4 from adafruit/jepler-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Hue to 1.1.5 from 1.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_Hue#16 from OBITORASU/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 2.2.1 from 2.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#64 from FoamyGuy/pylintrc > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#69 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_SSD1680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change fixes #58.
The SPI class was missing a page_addressing parameter, which is needed before the super call and use of the base _SSD1306 class. Thanks @dattrax for the testing and suggested fix. I agree this is the appropriate solution. Cheers!