Added a Signal Strength Function #11
Conversation
Added a function to return Signal Strength
|
So, the indentation looks good, but it's failing black. I'd start by installing black with pip. Then, run this in the repository folder: |
evaherrada
changed the title
|
|
||
|
|
||
| @property | ||
| def signalStrength(self): |
There was a problem hiding this comment.
Rename to signal_quality to avoid use of camel case and better match parameter name to ISU AT Command Reference.
|
@graemerae Keep trying. This is a really good PR to get more familiar with the general PR process. If you commit and push the changes to your PR branch, the updates will automatically be seen here and the checks will run again. No need for a new separate PR. |
|
@graemerae Are you still interested in working on this? |
|
If i can figure out how to do a pull request, yes.
… On Jan 6, 2021, at 9:01 AM, Kattni ***@***.***> wrote:
@graemerae <https://github.com/graemerae> Are you still interested in working on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#11 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4L575V7MGJ4C5FI4OFFSDSYSJM5ANCNFSM4SGZV3QA>.
|
|
@graemerae You can push to this PR branch and it will update this PR. I'm guessing you did it through GitHub though, which makes editing it a little more interesting. If you'd like to, you can make the changes and make a new PR with all the changes. Or, we have a guide on Contributing with Git and GitHub here that might help you figure out running things locally. If you're not already on the Adafruit Discord, we're also available there for questions. |
|
Closing. This was added with #15 and released with 1.2.0. Look for the new |
Added a function to return Signal Strength
(note previous PR was mangled because of an indent issue on my browser)