Skip to content

Initial Working Version #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 14, 2020
Merged

Initial Working Version #1

merged 9 commits into from
Sep 14, 2020

Conversation

makermelissa
Copy link
Collaborator

No description provided.

@makermelissa makermelissa requested a review from a team September 10, 2020 22:04
tannewt
tannewt reviewed Sep 11, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try subclassing framebuf to inherit all of the drawing functions?

If that doesn't work, I think you can simplify this by doing something like self.hline = self._framebuf.hline in __init__ for all pass through functions.

@makermelissa
Copy link
Collaborator Author

Good idea Scott. I had considered doing that, but wasn't sure if it was good practice. Changes are now made.

tannewt
tannewt approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner! Thank you!

@tannewt tannewt merged commit a58a4df into adafruit:main Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makermelissa @tannewt