Saving a bit of memory by punting frequently used ValueError("Out of range") to MIDIMessage. #3

Author: Kevin J Walters

adafruit_midi/channel_pressure.py

@@ -62,7 +62,7 @@ class ChannelPressure(MIDIMessage):
     def __init__(self, pressure):
         self.pressure = pressure
         if not 0 <= self.pressure <= 127:
-            raise ValueError("Out of range")
+            raise self._EX_VALUEERROR_OOR
 
     # channel value is mandatory
     def as_bytes(self, channel=None):

adafruit_midi/control_change.py

@@ -65,7 +65,7 @@ def __init__(self, control, value):
         self.control = control
         self.value = value
         if not 0 <= self.control <= 127 or not 0 <= self.value <= 127:
-            raise ValueError("Out of range")
+            raise self._EX_VALUEERROR_OOR
 
     # channel value is mandatory
     def as_bytes(self, channel=None):

adafruit_midi/midi_message.py

@@ -113,6 +113,9 @@ class MIDIMessage:
     CHANNELMASK = None
     ENDSTATUS = None
 
+    # Commonly used exceptions to save memory
+    _EX_VALUEERROR_OOR = ValueError("Out of range")
+
     # Each element is ((status, mask), class)
     # order is more specific masks first
     _statusandmask_to_class = []

adafruit_midi/note_off.py

@@ -66,7 +66,7 @@ def __init__(self, note, velocity):
         self.note = note_parser(note)
         self.velocity = velocity
         if not 0 <= self.note <= 127 or not 0 <= self.velocity <= 127:
-            raise ValueError("Out of range")
+            raise self._EX_VALUEERROR_OOR
 
     # channel value is mandatory
     def as_bytes(self, channel=None):

adafruit_midi/note_on.py

@@ -66,7 +66,7 @@ def __init__(self, note, velocity):
         self.note = note_parser(note)
         self.velocity = velocity
         if not 0 <= self.note <= 127 or not 0 <= self.velocity <= 127:
-            raise ValueError("Out of range")
+            raise self._EX_VALUEERROR_OOR
 
     # channel value is mandatory
     def as_bytes(self, channel=None):

adafruit_midi/pitch_bend_change.py

@@ -63,7 +63,7 @@ class PitchBendChange(MIDIMessage):
     def __init__(self, pitch_bend):
         self.pitch_bend = pitch_bend
         if not 0 <= self.pitch_bend <= 16383:
-            raise ValueError("Out of range")
+            raise self._EX_VALUEERROR_OOR
 
     # channel value is mandatory
     def as_bytes(self, channel=None):

adafruit_midi/polyphonic_key_pressure.py

@@ -65,7 +65,7 @@ def __init__(self, note, pressure):
         self.note = note_parser(note)
         self.pressure = pressure
         if not 0 <= self.note <= 127 or not 0 <= self.pressure <= 127:
-            raise ValueError("Out of range")
+            raise self._EX_VALUEERROR_OOR
 
     # channel value is mandatory
     def as_bytes(self, channel=None):

adafruit_midi/program_change.py

@@ -62,7 +62,7 @@ class ProgramChange(MIDIMessage):
     def __init__(self, patch):
         self.patch = patch
         if not 0 <= self.patch <= 127:
-            raise ValueError("Out of range")
+            raise self._EX_VALUEERROR_OOR
 
     # channel value is mandatory
     def as_bytes(self, channel=None):