Add missing type annotations #63
Conversation
pedrovs16
force-pushed
the
add-missing-type-annotations
branch
2 times, most recently
from
cc9a8fc to
e4631db
Compare
|
Already add missing types |
|
@kattni problem with docs and imports? |
|
Thanks @pedrovs16! I requested to be tagged so I can verify the documentation still looks right on RTD with the imports before the initial docstring. I'll look into it following the merge and release. |
adafruit_irremote.py
Outdated
| self, input_pulses, max_pulse=10000, pulse_window=0.10 | ||
| ): # pylint: disable=no-self-use | ||
| def _read_pulses_non_blocking( # pylint: disable=no-self-use | ||
| self, input_pulses: List, max_pulse: int = 10000, pulse_window: int = 0.10 |
There was a problem hiding this comment.
pulse_window looks like float I think instead of int
adafruit_irremote.py
Outdated
| max_pulse: int = 10000, | ||
| blocking: bool = True, | ||
| pulse_window: bool = 0.10, | ||
| blocking_delay: bool = 0.10, |
There was a problem hiding this comment.
both pulse_window and blocking_delay look like they can be float instead of bool
adafruit_irremote.py
Outdated
| @@ -341,14 +351,24 @@ class GenericTransmit: | |||
| :param bool debug: Enable debug output, default False | |||
| """ | |||
|
|
|||
| def __init__(self, header, one, zero, trail, *, debug=False): | |||
| def __init__( | |||
| self, header: int, one: int, zero: int, trail: int, *, debug=False | |||
There was a problem hiding this comment.
debug can be typed as bool
adafruit_irremote.py
Outdated
| *, | ||
| repeat: int = 0, | ||
| delay: int = 0, | ||
| nbits: int = None, |
There was a problem hiding this comment.
for nbits since the default value is None I think it can be Optional[int]
pedrovs16
force-pushed
the
add-missing-type-annotations
branch
from
7fa7d72 to
2f4f7e7
Compare
pedrovs16
force-pushed
the
add-missing-type-annotations
branch
from
2f4f7e7 to
42a046e
Compare
There was a problem hiding this comment.
This looks good to me now. Thanks again for working on it @pedrovs16!
I made one commit with a tweak to us float instead of int for delay. It was typed as float in the sphinx docstring already and I confirmed on a device that passing floats is acceptable.
Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 4.1.15 from 4.1.14: > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#63 from pedrovs16/add-missing-type-annotations > Update pre-commit hooks Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 5.2.3 from 5.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_Logging#50 from FoamyGuy/jquery_fix > Merge pull request adafruit/Adafruit_CircuitPython_Logging#49 from tyeth/patch-1 > Update pre-commit hooks > Add upload url to release action Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Fixing to issue #50