Split serve_forever to allow polling in loop and add another example with polling in while loop. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 1, 2022 20:35
Add polling example. Fix root_path bug when loading static pages.
dhalbert
approved these changes
Jul 6, 2022
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 6, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.12.8 from 1.12.7: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#62 from tom24/udpfixes Updating https://github.com/adafruit/Adafruit_CircuitPython_Dash_Dis to 1.1.7 from 1.1.6: > Merge pull request adafruit/Adafruit_CircuitPython_Dash_Dis#5 from Neradoc/add-requirements Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.5.0 from 2.4.6: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#50 from bablokb/sparkline_opt Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 0.2.0 from 0.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#7 from karlfl/main Updating https://github.com/adafruit/Adafruit_CircuitPython_OAuth2 to 1.0.10 from 1.0.9: > Merge pull request adafruit/Adafruit_CircuitPython_OAuth2#8 from tcfranks/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split out the logic from the serve_forever into two methods start() and poll(). This will allow developers to do other work in the while loop while still processing the web requests. The original method now calls these two methods so that any existing code will still work. Tested it using both of the existing examples and added a third that implements the start() and poll() functions.