Update adafruit_espatcontrol_socket.py #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got error when using adafruit_espatcontrol_socket.py and adafruit_minimqtt when I use port 1883 for MQTT, it is due to connection type is not defined for port 1883
Traceback (most recent call last):
File "code.py", line 117, in
File "/lib/adafruit_minimqtt/adafruit_minimqtt.py", line 447, in connect
File "/lib/adafruit_minimqtt/adafruit_minimqtt.py", line 270, in _get_connect_socket
File "/lib/adafruit_espatcontrol/adafruit_espatcontrol_socket.py", line 85, in connect
File "/lib/adafruit_espatcontrol/adafruit_espatcontrol.py", line 202, in socket_connect
RuntimeError: Connection type must be TCP, UDL or SSL
I propose to add conntype TCP for port 1883 in the condition