Skip to content

Examples and tests for debugging #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dannystaple
Copy link
Contributor

No description provided.

@tannewt tannewt requested a review from dhalbert May 31, 2022 20:55
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

I am making some extensive changes in #167 (not yet merged): removing non-standard stuff from socket, and removing the wsgi_server stuff entirely.

@dannystaple
Copy link
Contributor Author

Thanks for this!

I am making some extensive changes in #167 (not yet merged): removing non-standard stuff from socket, and removing the wsgi_server stuff entirely.

Hmm - I am preparing to do some quite interesting things with the WSGI server (and possibly see about websockets, but that may be stretching too far). Perhaps we can find a time to discuss the future of this on discord when we are both on? I've had some stability struggles with this, that I traced into NINA-FW. adafruit/nina-fw#46 - so looking at alternatives. The overall plan is a metrics/teleop system in circuitpython on a Pico + Airlift robot.

@dhalbert
Copy link
Contributor

dhalbert commented Jun 1, 2022

Hmm - I am preparing to do some quite interesting things with the WSGI server (and possibly see about websockets, but that may be stretching too far).

I want server stuff to be outside this library, so we can use it with multiple socket implementations (ESP32-S2, etc.). So I'd really like to see https://github.com/adafruit/Adafruit_CircuitPython_WSGI be better developed. Could you see going that direction?

I've had some stability struggles with this, that I traced into NINA-FW. adafruit/nina-fw#46 - so looking at alternatives.

I did not see this report, thanks -- it may have relevance to some other problems we are seeing with ESP32SPI.

@dannystaple
Copy link
Contributor Author

That sounds good indeed - it also invites other socket protocol types to be made in the same way. I am about to disappear to EMFCamp, but it might be good to discuss and perhaps see if I can pitch in teasing these apart when i am back.

@FoamyGuy
Copy link
Contributor

FoamyGuy commented Aug 7, 2023

Checking in on this one, @dannystaple are you still interested in circling back to this effort?

It may end up being easiest to close this PR and open new one(s) if so.
There are a number of changes that could be complex with the current state of this PR:

@dannystaple
Copy link
Contributor Author

dannystaple commented Aug 8, 2023 via email

@FoamyGuy FoamyGuy closed this Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants