Skip to content

PWM Frequency Bug #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxbec opened this issue Feb 7, 2021 · 6 comments
Closed

PWM Frequency Bug #3

maxbec opened this issue Feb 7, 2021 · 6 comments

Comments

@maxbec
Copy link
Contributor

maxbec commented Feb 7, 2021

Hi guys,

shouldn't this be (look at the last line):

    @pwm_frequency.setter
    def pwm_frequency(self, value):
        if value < 0 or value > 0x1F:
            raise AttributeError("pwm_frequency must be from 0-31")
        self._pwm_freq_div = value
    @pwm_frequency.setter
    def pwm_frequency(self, value):
        if value < 0 or value > 0x1F:
            raise AttributeError("pwm_frequency must be from 0-31")
        self._pwm_freq = value
@ladyada
Copy link
Member

ladyada commented Feb 7, 2021

ya looks like a copy paste error - wanna try submitting a PR fix? :)

@maxbec
Copy link
Contributor Author

maxbec commented Feb 7, 2021

Yes! Will add it!

@maxbec
Copy link
Contributor Author

maxbec commented Feb 8, 2021

PR added! :)

@ladyada ladyada closed this as completed in 15d704e Feb 8, 2021
ladyada added a commit that referenced this issue Feb 8, 2021
@maxbec
Copy link
Contributor Author

maxbec commented Feb 9, 2021

Can you guys make a new release? So that we can use the library? :)

@ladyada
Copy link
Member

ladyada commented Feb 9, 2021

hihi we do sweeps a few times a week - @dherrada will be sweeping it!

@evaherrada
Copy link
Collaborator

@maxbec Yep. Just released it.

stoklund added a commit to stoklund/Adafruit_CircuitPython_EMC2101 that referenced this issue Oct 30, 2021
This was previously fixed in adafruit#4, but it looks like the fix got clobbered when the LUT code was split out to a separate file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants