-
Notifications
You must be signed in to change notification settings - Fork 39
New parameter and example creation for testing and future reference #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New parameter and example creation for testing and future reference #115
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jposada202020. I'm not sure what I saw last time but it does seem all good now with the Fayette font.
I think is pretty close to ready. It seems that when I merged the scale PRs it caused merge conflicts here. I think it can be resolved if you merge master into this branch. Let me know if you'd like help though, I'm happy to help out.
I'd like to get a simplified example if we can as well.
After those things I think this is probably good to go! Thanks again for working on this!
@FoamyGuy Thanks for the revision, thanks for all the suggestions, For the code, you are right, I was just trying to find where the problem was :) ...I think I will use original code by @endico in issue #103 for the example. And also make the changes as suggested. Thanks for the review. And for your time 👍🏼 |
...I forgot "it caused merge conflicts here. I think it can be resolved if you merge master into this branch. Let me know if you'd like help though, I'm happy to help out." Yes, I will need help with that. I will ping you when other changes are ready |
I ran the example code with a few different font files and it works great! The Large font that's in the example wasn't in the repository |
# Conflicts: # adafruit_display_text/label.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I see the conflicts are handled now.
@FoamyGuy I changed the example to include both 4 labels in the screen at all times, Thanks for the comments reviews, and help with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested these changes successfully on PyPortal and MagTag. Changes look good to me. Thanks for working on this @jposada202020!
Here is how the new example looks on a MagTag:
I changed the big font to one I had available and adjusted the positions slightly to fit the magtag screen better.
@FoamyGuy Team Work!!!! Thanks! You save us some time for the documentation :). Thank you |
@jposada202020 this is really helpful. Thanks for adding. Do you plan to do the same for the bitmap_label version? |
Yes no problem. I will like to take a look at bitmap_label at the same time to do the Documentation (Including/Excluding features compared with Label) if that is ok?. So give me until the weekend :) |
Updating https://github.com/adafruit/Adafruit_CircuitPython_datetime to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_datetime#2 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.14.0 from 2.12.4: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#120 from jposada202020/bitmap_label_base_alignment > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#115 from jposada202020/base_alignement_proposal
With this change, we are adding a new parameter called base_alignment in the label library. Also we are including some tests to compare old behavior vs New behavior. This will address issues #103 and #100.
For back-compatibility parameter is set to False by default, that way old code created will still function with the new version