Skip to content

README.md - Retry values after 1/2 seconds returns cached values #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yashino91 opened this issue Feb 27, 2020 · 1 comment
Closed

Comments

@yashino91
Copy link

yashino91 commented Feb 27, 2020

Hi there!

Thank you for providing this library :)

README.md states that you should try to get the values again ​​after 1/2 second, if a RuntimeError has occurred. However, the measurement function in your library has the delay_between_readings property, which is set to 2 seconds.
So if you try to read again within 2 seconds, the function does not update the temperature / humidity properties and returns cached values.

I don't know if that's exactly what you wanted to communicate, but for me it was not clear and caused some confusion. If you want a new reading after failure, you have to wait at least 2 seconds. That's totally ok, but maybe you update your readme to clarify this behaviour.

Best Regards,
Stefan

@ladyada
Copy link
Member

ladyada commented Feb 27, 2020

true! wanna submit a typo fix PR ? :)

yashino91 pushed a commit to yashino91/Adafruit_CircuitPython_DHT that referenced this issue Feb 28, 2020
ladyada added a commit that referenced this issue Feb 28, 2020
@ladyada ladyada closed this as completed Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants