-
Notifications
You must be signed in to change notification settings - Fork 7
Moved repository from Travis to GitHub Actions #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Personally, I think the best course of action for this would be reverting the most recent commit |
@dherrada This is failing for a documentation build issue and it was already failing, though it may have been hard to tell because what looks like a typo in the cookiecutter setup broke the link to Travis. It's here: Can you give more detail about why you were suggesting reverting the most recent commit? |
@siddacious Prior to the most recent commit, the only issues were pylint issues in the docstring of adafruit__cpython.py. In fixing the pylint issues, I messed up some of the rst which caused it to fail. |
adafruit__cpython.py
Outdated
@@ -32,15 +32,17 @@ | |||
|
|||
**Hardware:** | |||
|
|||
.. todo:: Add links to any specific hardware product page(s), or category page(s). Use unordered list & hyperlink rST | |||
.. todo:: Add links to any specific hardware product page(s), or category |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your attempts to get this passing are admirable but RST doesn't play fair. You can undo this.
adafruit__cpython.py
Outdated
|
||
.. todo:: Uncomment or remove the Bus Device and/or the Register library dependencies based on the library's use of either. | ||
|
||
.. todo:: Uncomment or remove the Bus Device and/or the Register library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be reverted as well
@dherrada ah! I see what you mean. Ya, go ahead and revert the TODO changes |
@siddacious Ok. Will rebase in 1 sec |
a5826de
to
230793e
Compare
No description provided.