Skip to content

Moved repository from Travis to GitHub Actions #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 10, 2020

Conversation

evaherrada
Copy link
Collaborator

No description provided.

@evaherrada evaherrada requested a review from siddacious January 9, 2020 22:36
@evaherrada
Copy link
Collaborator Author

Personally, I think the best course of action for this would be reverting the most recent commit

@siddacious
Copy link
Contributor

@dherrada This is failing for a documentation build issue and it was already failing, though it may have been hard to tell because what looks like a typo in the cookiecutter setup broke the link to Travis. It's here:
https://travis-ci.com/adafruit/Adafruit_CircuitPython_CPython

Can you give more detail about why you were suggesting reverting the most recent commit?

@evaherrada
Copy link
Collaborator Author

@siddacious Prior to the most recent commit, the only issues were pylint issues in the docstring of adafruit__cpython.py. In fixing the pylint issues, I messed up some of the rst which caused it to fail.

@@ -32,15 +32,17 @@

**Hardware:**

.. todo:: Add links to any specific hardware product page(s), or category page(s). Use unordered list & hyperlink rST
.. todo:: Add links to any specific hardware product page(s), or category
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your attempts to get this passing are admirable but RST doesn't play fair. You can undo this.


.. todo:: Uncomment or remove the Bus Device and/or the Register library dependencies based on the library's use of either.

.. todo:: Uncomment or remove the Bus Device and/or the Register library
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be reverted as well

@siddacious
Copy link
Contributor

@dherrada ah! I see what you mean. Ya, go ahead and revert the TODO changes

@evaherrada
Copy link
Collaborator Author

@siddacious Ok. Will rebase in 1 sec

@siddacious siddacious merged commit 03df9a8 into master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants