Add type annotations #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
reviewed
Mar 16, 2022
| @@ -52,7 +57,7 @@ def hls_to_rgb(hue, light, sat): | |||
| ) | |||
|
|
|||
|
|
|||
| def _v(chroma1, chroma2, hue): | |||
| def _v(chroma1: float, chroma2: float, hue: float) -> float: | |||
There was a problem hiding this comment.
It's not really specifically related to this PR but I'm curious if you know what this _v function is doing? I don't recognize the algorithm in it (tho I have little experience with light sensors and related things).
I wonder if there is a more descriptive name that we could use for it.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 17, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_FXOS8700 to 2.1.12 from 2.1.11: > Merge pull request adafruit/Adafruit_CircuitPython_FXOS8700#27 from tekktrik/doc/add-typing > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_Colorsys to 2.0.4 from 2.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_Colorsys#19 from tekktrik/doc/add-typing > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_HTTPServer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18 by adding type annotations!