Skip to content

Updated package name, function name in README.rst cdoe example #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 7, 2021
Merged

Updated package name, function name in README.rst cdoe example #15

merged 4 commits into from
Dec 7, 2021

Conversation

romilly
Copy link
Contributor

@romilly romilly commented Mar 1, 2021

The code example in README.rst was only partially updated when the API was changed.

ladyada
ladyada approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@ladyada
Copy link
Member

ladyada commented Mar 1, 2021

@dherrada here's a dupcode CI error

@ladyada ladyada requested a review from evaherrada March 1, 2021 22:38
@evaherrada
Copy link
Collaborator

@ladyada After #16 is merged, I think this pr should pass

@ladyada
Copy link
Member

ladyada commented Mar 1, 2021

@romilly can you 'bump' this PR?

@evaherrada
Copy link
Collaborator

@romilly I think what you've got to do is merge adafruit/master into your fork. I'm not super good at git, but I think you've got to add the adafruit fork as a remote, then fetch adafruit/master, then merge it into romilly/master

@kmatch98
Copy link
Contributor

kmatch98 commented Apr 11, 2021 •
edited
Loading

The latest edit uses an “out of date” solution for the “streak problem”. The solution that was chosen to merge was done in this issue: #14. It prevents the buffer from being reallocated.

(Strangely the file diff doesn’t show how this differs from the released version. Strange or maybe I’m missing something. )

Can you update your merge to match the released version?

@jposada202020
Copy link
Contributor

@romilly as @kmatch98 mentioned this was solved with an improved solution. Could you modify the current PR to modify the Readme.rst file only? let me know thanks

@jposada202020 jposada202020 added the documentation Improvements or additions to documentation label May 13, 2021
@evaherrada evaherrada changed the base branch from master to main June 3, 2021 14:47
lesamouraipourpre
lesamouraipourpre reviewed Sep 18, 2021
View reviewed changes
Copy link

@lesamouraipourpre lesamouraipourpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

adafruit_bitmapsaver.py
@@ -91,6 +91,7 @@ def _write_pixels(output_file, pixel_source, palette):
color >>= 8
buffer_index += 1
else:
result_buffer = bytearray(2048)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result_buffer line at Line 82 could be removed as it is no longer needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @lesamouraipourpre. I removed that unused copy of the variable with latest commit

FoamyGuy
FoamyGuy approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
tested successfully with:

Adafruit CircuitPython 7.1.0-beta.0 on 2021-11-12; Adafruit PyPortal with samd51j20
Board ID:pyportal

@FoamyGuy FoamyGuy merged commit ee995f3 into adafruit:main Dec 7, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 7, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@628f852)
1f55bbb 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADT7410 to 1.3.0 from 1.2.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADT7410#17 from jposada202020/adding_critical_temp_features
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_LTR390 to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_LTR390#13 from caternuson/iss11
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_BitmapSaver to 1.1.8 from 1.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_BitmapSaver#15 from romilly/master
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Eddystone to 1.0.7 from 1.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Eddystone#15 from tekktrik/docfix/add-blinka-req
  > update rtd py version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesamouraipourpre lesamouraipourpre lesamouraipourpre left review comments

@ladyada ladyada ladyada approved these changes

@FoamyGuy FoamyGuy FoamyGuy approved these changes

@evaherrada evaherrada Awaiting requested review from evaherrada

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@romilly @ladyada @evaherrada @kmatch98 @jposada202020 @FoamyGuy @lesamouraipourpre