Skip to content

changed getattr() calls to chip.get() to correct clock_speed override code #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2021
Merged

changed getattr() calls to chip.get() to correct clock_speed override code #30

merged 1 commit into from
Dec 1, 2021

Conversation

aarontusko
Copy link
Contributor

The code to override the default clock_speed was incorrectly looking for an attribute instead of a key/value pair.

@FoamyGuy
Copy link
Contributor

FoamyGuy commented Dec 1, 2021

The changes in this PR originally came from #25 . There are some more specific details in that PR / comment chain for anyone seeing this in the future looking for more information about it.

FoamyGuy
FoamyGuy approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. The root cause of the issue and proposed solution both make sense to me.

Tested successfully with Feather RP2040 on 7.1.0 beta using the avrprog_program_uno328.py from the examples directory in this repo.

@FoamyGuy FoamyGuy merged commit c4d3e00 into adafruit:main Dec 1, 2021
@FoamyGuy FoamyGuy mentioned this pull request Dec 1, 2021
Closed
@aarontusko aarontusko deleted the clock_speed-fix branch December 1, 2021 16:37
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 2, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@628f852)
c5cd85b 
Updating https://github.com/adafruit/Adafruit_CircuitPython_AVRprog to 1.4.1 from 1.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#30 from aarontusko/clock_speed-fix
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.10.0 from 1.9.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#53 from makermelissa/main
  > update rtd py version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarontusko @FoamyGuy