Skip to content

Commit e24821a

Browse files
committed
update url_pattern to pass more wpt on node.js
1 parent ecdb978 commit e24821a

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

include/ada/implementation.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ bool can_parse(std::string_view input,
5353
* @param input valid UTF-8 string or URLPatternInit struct
5454
* @param base_url an optional valid UTF-8 string
5555
* @param options an optional url_pattern_options struct
56-
* @param provider an optional regex provider. if not provided, it will
57-
* use ada::url_pattern_regex::std_regex_provider
5856
* @return url_pattern instance
5957
*/
6058
template <url_pattern_regex::regex_concept regex_provider =

include/ada/url_pattern-inl.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,6 @@ url_pattern_component<regex_provider>::create_component_match_result(
4646
auto result =
4747
url_pattern_component_result{.input = std::string(input), .groups = {}};
4848

49-
// If input is empty, then groups will always be empty.
50-
if (input.empty() || exec_result.empty()) {
51-
return result;
52-
}
53-
5449
// Optimization: Let's reserve the size.
5550
result.groups.reserve(exec_result.size() - 1);
5651

0 commit comments

Comments
 (0)